X-Plane / XPlane2Blender

Scenery & Aircraft export addon for Blender and X-Plane
GNU General Public License v3.0
197 stars 67 forks source link

Block use of sim/multiplayer datarefs #405

Open tngreene opened 5 years ago

tngreene commented 5 years ago

sim/multiplayer/* datarefs are bad bad bad. We shouldn't allow the 2.7x to add them to it's dataref lookup dictionary, and we should emit an error and tell the person to choose something else (maybe we can suggest an alternative?)

We'll doc this in the release notes. Users won't notice something hidden and the error clearly states what's going on. Plus, there is this record here.

kbrandwijk commented 5 years ago

Regarding 'block addition', should they simply be skipped when reading datarefs.txt, or should an explicit error be thrown?

tngreene commented 5 years ago

Since sim/multiplayer will (probably) always be in Datarefs.txt, we can't give people an error during the file loading. We'll just ignore it.

If someone is using it as a dataref, we need to give a full on error in the logger and force them to choose a different one.