search

X-Raym / REAPER-ReaScripts

X-Raym's Free and Open Source Scripts for Cockos REAPER.
http://www.extremraym.com/en/my-reaper-scripts/
GNU General Public License v3.0
182 stars 51 forks source link

Fix: Fade out options not working #6

Closed jalovatt closed 6 years ago

jalovatt commented 6 years ago

main()'s if/then/else logic wasn't using the input values in the same order that they were given by the dialog box.

jalovatt commented 6 years ago

Also, the wording in the dialog box is a little confusing IMO. Perhaps "Keep", "Ignore", "Exclude"?

X-Raym commented 6 years ago

@jalovatt I'm surprised there was an error, but I'll trust you on this 🐱 If is one of my early script, if I had to recode it, I will indeed change the wording, and most of all, add shortcuts and aliases, like "0/n/false/exclude/e/x" for exclude and "1/y/true/keep/k" for keeping, and simply "i" for ignore, and the whole feeling case insensitive.

But I don't know how much this script is used, it may not worth that level of attention ^^ Unless you want to update it, I'll merge the pull request as it is.

jalovatt commented 6 years ago

I just had a look and it would need a bit of recoding for my wording to make sense. Don't worry about it.

X-Raym commented 6 years ago

@jalovatt Thanks for your contribution !