search

X-Ryl669 / eMQTT5

An embedded MQTTv5 client in C++ with minimal footprint, maximal performance
MIT License
65 stars 14 forks source link

#include "../../something/something.hpp" is not easy to read #6

Closed shinyaohtani closed 3 years ago

shinyaohtani commented 3 years ago

close #5

include <something/something.hpp> is better. There is no problem if this PR is not merged, but since I noticed this, I issued it as PR.

shinyaohtani commented 3 years ago

ESP32's build system

Ah, that certainly has to be confirmed. I can't cooperate because I don't have the ESP32 right now. I'm sorry.

X-Ryl669 commented 3 years ago

You have removed a lot of configuration code from the project, so I can't accept this patch as is. I've implemented and reincluded the ideas you've spotted here, it's pushed in master. I advise you to merge the change to ensure it fits your need. Cheers!

shinyaohtani commented 3 years ago

@X-Ryl669 I'm very sorry for the confusion. I forgot making a brach for the Pull Request. https://github.com/X-Ryl669/eMQTT5/pull/6/commits/3980171e7f1892fa15250b20319b6cd494d43e73 and https://github.com/X-Ryl669/eMQTT5/pull/6/commits/32a51db6e8bd05be1718b3a13ffa60064c9cdb89 was meant to be a completely private change and I didn't intend to include it in the pull request. Really sorry.

shinyaohtani commented 3 years ago

Please close this PR without merge.

X-Ryl669 commented 3 years ago

Ok, so I'm closing this. Have a nice day!