Implement toggle for scrolling and add config for a viewport-offset

X-Ryl669 / grav-plugin-markdown-collapsible

MIT License

3 stars 4 forks source link

Implement toggle for scrolling and add config for a viewport-offset #7

Closed evansharp closed 9 months ago

evansharp commented 9 months ago

This PR adds two features to the plugin with admin-console UI:

Can toggle off the scroll-to-content behaviour
Can specify an offset for the scroll-to-content that positions the viewport better for sticky headers and such.

This is my first time working with Grav under the hood, so please check my code for anything I've missed that needs to be done.

X-Ryl669 commented 9 months ago

Nice idea, thanks for the work. I've just one small remark to avoid having the same inline style code for each label element in the collapsible. Please try the suggestion and if it work, I think it's better that way since it'll produce less code. Else, I'll merge your PR.