search

X-SLAYER / flutter_accessibility_service

Flutter plugin for interacting with Accessibility Service in Android.
https://pub.dev/packages/flutter_accessibility_service
MIT License
37 stars 27 forks source link

[Query] Fix for StackOverflow in `getSubNodes` #16

Closed sarthakydv closed 10 months ago

sarthakydv commented 11 months ago

There have been recent changes in the package to make a fix for this issue.

Can you please explain how it is fixed?

If not fixed, I would love to discuss on how we can do it.

A team member has added a set to handle duplicates but It feels unreliable because of generateNodeId (E.g. In a chat application, parent node can be the same user name for multiple entries)

PR for changes by @avisihag #15

sarthakydv commented 11 months ago

@avisihag has removed dependence on generateNodeId

Please take a look

X-SLAYER commented 11 months ago

Sure I'll check it and merge thanks

sarthakydv commented 11 months ago

@X-SLAYER your recent changes did not address this issue?

X-SLAYER commented 11 months ago

i didn't come to a case that stuck in a loop of subnodes

sarthakydv commented 10 months ago

@X-SLAYER The fix is working well, can you please merge and make a release?

avisihag commented 10 months ago

i didn't come to a case that stuck in a loop of subnodes

Our app is getting repeated instances of Fatal Exception: java.lang.StackOverflowError: stack size 8188KB in the getNextTexts function which is moved to getSubNodes in the latest release.

Please have a look at the PR I've raised to fix this particular issue.

X-SLAYER commented 10 months ago

PL request merged wait till i post a new version of the app

X-SLAYER commented 10 months ago

New version is up