[Bug] Ranking List component is breaking on the docs site

X-lab2017 / open-digger-website

Official Website for OpenDigger Community

https://open-digger.cn

Apache License 2.0

6 stars 6 forks source link

[Bug] Ranking List component is breaking on the docs site #8

Closed Neilblaze closed 3 months ago

Neilblaze commented 3 months ago

I'm sharing a preview of the same here. / cc: @frank-zsy
Bug

frank-zsy commented 3 months ago

@Neilblaze I am not sure how to reproduce the issue. I raised a PR #14 which will fix the crash caused by JSON parse exception but from the video you uploaded, I don't think I reproduce the same bug.

Neilblaze commented 3 months ago

@frank-zsy Interesting, the bug (#8) that I raised was tested on Chromium [ version 124.0.6367.202 (Official Build) (64-bit) ] on Windows 10 (x64). I just pulled in the changes on my Ubuntu (22.04 LTS) and tried to reproduce the bug on local via Chromium as well as Firefox, and everything seems to be working fine.

I feel it was OS dependent glitch (specific to Windows 10), so things are just fine. And now I just reviewed your PR #14, and it lgtm! We can get it merged if you want.

frank-zsy commented 3 months ago

@Neilblaze OK, we can fix this if anyone file the issue again later.