X-lab2017 / open-digger

Open source analysis tools
https://open-digger.cn
Apache License 2.0
281 stars 78 forks source link

Add New Functions and Add examples: An almost covering all existing functions version of pycjs kerel with some preliminary testing #1506

Closed birdflyi closed 5 months ago

birdflyi commented 5 months ago

Purpose

Changes

Notes

frank-zsy commented 5 months ago

LGTM, thanks.

And openDigger.quick is a legacy API which is deprecated right now and should be removed from the lib, I will do this soon.

frank-zsy commented 5 months ago

And like fixed in #1507 with the default config time value, right now for Jan. 2024, if you do not set the endYear and endMonth manually, it will cause a bug in the SQL which leads to the TOO_LARGE_ARRAY_SIZE problem, it should be fixed after above PR merged.

birdflyi commented 5 months ago

LGTM, thanks.

And openDigger.quick is a legacy API which is deprecated right now and should be removed from the lib, I will do this soon.

OK, I'll remove the replacement function(implemented in python) of this deprecated function openDigger.quick as well.

birdflyi commented 5 months ago

And like fixed in #1507 with the default config time value, right now for Jan. 2024, if you do not set the endYear and endMonth manually, it will cause a bug in the SQL which leads to the TOO_LARGE_ARRAY_SIZE problem, it should be fixed after above PR merged.

Great! This kind of Exception always confuses me with a hint TOO_LARGE_ARRAY_SIZE.