X-lab2017 / open-leaderboard

OpenLeaderboard
https://open-leaderboard.x-lab.info
20 stars 23 forks source link

[Bug] default language conflict #28

Open gymgym1212 opened 2 years ago

gymgym1212 commented 2 years ago

Switching the language for the first time does not work. When the page loads, the language is Chinese at first, but it is still Chinese after clicking on the switch. The toggle button does not work properly until after the first toggle.

tyn1998 commented 1 year ago

I'm not sure if the bug has been fixed as language switching function works well on my side at the moment:

https://user-images.githubusercontent.com/32434520/220509894-737713bc-3a60-4fbe-9a20-37914b8fa5f3.mov

andyhuang18 commented 1 year ago

When the default interface is in Chinese, problems will occur on the first click

https://user-images.githubusercontent.com/50283262/220513292-4999146d-60d9-4e83-a419-003ad6475d63.mp4

tyn1998 commented 1 year ago

Reproduced:

  1. set language to en
  2. refresh the page
  3. now zh is the default language
  4. click toggle button, the problem is reproduced
andyhuang18 commented 1 year ago

Reproduced:

  1. set language to en
  2. refresh the page
  3. now zh is the default language
  4. click toggle button, the problem is reproduced

Copy that!I will continue to work on this issue~

tyn1998 commented 1 year ago

I just put steps to reproduce the bug here. The issue was fixed by your PR :)

wj23027 commented 1 year ago

I find that now when the language is English there are still some problems.

https://user-images.githubusercontent.com/62098023/220529917-1819e998-e641-4d53-a29f-5bed75702595.mp4

tyn1998 commented 1 year ago

My fault, I didn't test it in the other way around.