Closed zhicheng-ning closed 1 year ago
Can you please provide design to this, I will start working on the same. Or just we need to add "source" button and on click of that the user should navigate to the new tab with github project link?
I think maybe we can refer to the button icon next to it and find a suitable icon for the button.
I downloaded a github icon image and adjusted the color to a similar theme to the icon next to it. What do you guys think of this icon?
I downloaded a github icon image and adjusted the color to a similar theme to the icon next to it. What do you guys think of this icon?
It's nice for me.
Can you please assign this to me? I can work on this and will create a PR within some time.
I downloaded a github icon image and adjusted the color to a similar theme to the icon next to it. What do you guys think of this icon?
According to GitHub Logos and Usage, it is not recommended to change the color of github logo. I think we can directly use the original Github logo.
I downloaded a github icon image and adjusted the color to a similar theme to the icon next to it. What do you guys think of this icon?
According to GitHub Logos and Usage, it is not recommended to change the color of github logo. I think we can directly use the original Github logo.
OK!You get the point.
Hi~@kunal8411 Thank you for your interest and enthusiasm for this project! If you encounter any problems, you can leave a message here.
I have adde the GitHub logo like this, as it it , Can you please check and let me know if its correct or not or should i modify some things here?
If everything is okay, I will send PR with the function to redirect user to GitHub once click on GitHub logo. Thanks
I have adde the GitHub logo like this, as it it , Can you please check and let me know if its correct or not or should i modify some things here?
If everything is okay, I will send PR with the function to redirect user to GitHub once click on GitHub logo. Thanks
I think there is still room for improvement in this design. You should take into account the overall layout coordination. The style of the icons should be consistent. The spacing of the icons could be a little bit larger.
I have adde the GitHub logo like this, as it it , Can you please check and let me know if its correct or not or should i modify some things here?
It is not recommended to change the style of github logo, so it is better to use the original github logo directly, and then you can submit a PR, thank you for your contribution!
Original logo will look like this(with black background color), is this okay?
Thanks! I think it's pretty good. Make a small suggestion: can you leave a little space between several icons? 😄
Yes I will do this change.
Created the PR, also added the "GitHub" list item for mobile screen, Can you guys please check.
Thanks.
Hi @kunal8411 Thanks for your contribution! This is important to our community! 😄
For this collaboration, I would like to give you some suggestions:
I am very glad that you can pay attention to our project. If you have other suggestions for this project, you can create a new issue. We are looking forward to this. ❤️
Thanks a lot @andyhuang18 . I will keep this in mind from next time. Enjoyed working on this project, looking forward to work more on this. Thanks a lot.