X-lab2017 / open-leaderboard

OpenLeaderboard
https://open-leaderboard.x-lab.info
20 stars 22 forks source link

fix: change month judgment logic #96

Closed andyhuang18 closed 1 year ago

andyhuang18 commented 1 year ago

Brief Information

This pull request is in the type of (more info about types):

Related issues (all available keywords):

Details

目前修改的情况为下图所示。在调试环境中,我设定在6号之前,数据还处于未更新状态,因此当我选择 2023-06 时,红圈位置会显示提示信息。在我提交 Commit 的内容里,我设定在4号之前。目前未更新状态时会显示上上个月的数据。

shot

Checklist

Others

tyn1998 commented 1 year ago

目前修改的情况为下图所示。在调试环境中,我设定在6号之前,数据还处于未更新状态,因此当我选择 2023-06 时,红圈位置会显示提示信息。在我提交 Commit 的内容里,我设定在4号之前。目前未更新状态时会显示上上个月的数据。

shot

这个描述我没有很懂,于是gh pr checkout了这个分支,然后把4都改成了6,试了一下,和你的截图不一样:

image

另外,这个提示“请注意:xxx”我觉得也不大好懂,可以再适当组织一下语言~

andyhuang18 commented 1 year ago

Hi @tyn1998 帮忙审阅一下新修改的代码,谢谢~

tyn1998 commented 1 year ago

@andyhuang18 LGTM, thank you very much!

tyn1998 commented 1 year ago

I should have run the code locally 😆

directly pushed another commit to main to solve the problem.

wj23027 commented 1 year ago

我有个小疑问,是open-leaderboard的所有数据都会延迟4天更新还是只是大屏延迟更新呢?

andyhuang18 commented 1 year ago

我有个小疑问,是open-leaderboard的所有数据都会延迟4天更新还是只是大屏延迟更新呢?

都会延迟更新