X16Community / x16-emulator

Emulator for the Commander X16 8-bit computer
BSD 2-Clause "Simplified" License
205 stars 44 forks source link

PCM Audio Rate might not match hardware #209

Open Yazwh0 opened 10 months ago

Yazwh0 commented 10 months ago

The emulator looks like it does something when a signed value is written to the PCM Audio Rate.

I can't find anything in the Vera code that matches this logic. The commit comment mentions its to do with PCM looping, but as that hasn't been merged, should this be here?

pcm_write_rate(uint8_t val)
{
    rate = (val > 128) ? (256 - val) : val;
}
mooinglemur commented 9 months ago

We will need to resolve this based on the outcome of https://github.com/X16Community/vera-module/pull/24