Fix X2Effect_BonusWeaponDamage damage preview

X2CommunityCore / X2WOTCCommunityHighlander

https://steamcommunity.com/workshop/filedetails/?id=1134256495

MIT License

60 stars 68 forks source link

Fix X2Effect_BonusWeaponDamage damage preview #1307

Open Iridar opened 8 months ago

Iridar commented 8 months ago

Fixes #612 Requires #1306

Iridar commented 8 months ago

I realized that custom damage effects may not always call the new GetAttackingDamageModifier_CH(), so it's preferable to use it only for the purposes of damage preview. I brought back the original implementation of GetAttackingDamageModifier() so that in cases like that it can still apply the bonus damage correctly, even if it will not be displayed in the damage preview.

Iridar commented 8 months ago

In testing the new implementation doesn't work, to be fixed.