Correcting Faceoff_BuildVisualization to properly visualize bonus weapon and ammo effects that it already applies.
Correct TypicalAbility_FillOutGameState to apply bonus weapon and ammo effects to multi targets that it already applies to primary target.
Correct TypicalAbility_BuildVisualization to visualize bonus weapon and ammo effects being applied to multi targets.
Make Saturation Fire apply bonus weapon and ammo effects.
Case for the latter change: the description of Saturation Fire says:
Saturation Fire will take a standard shot at every enemy in the cone, and will damage or destroy random cover elements in the cone.
So logically it should apply bonus weapon and ammo effects at multi targets, because standard shots do that, so that's how the player will expect the ability to behave. The fact that an ability that directly involves you shoot your weapon with a specific ammo at specific targets, but does not apply weapon and ammo effects to those targets, is obviously a bug and should be fixed.
Fixes #1329
This PR fixes the issue by:
Faceoff_BuildVisualizationto properly visualize bonus weapon and ammo effects that it already applies.TypicalAbility_FillOutGameStateto apply bonus weapon and ammo effects to multi targets that it already applies to primary target.TypicalAbility_BuildVisualizationto visualize bonus weapon and ammo effects being applied to multi targets.Case for the latter change: the description of Saturation Fire says:
So logically it should apply bonus weapon and ammo effects at multi targets, because standard shots do that, so that's how the player will expect the ability to behave. The fact that an ability that directly involves you shoot your weapon with a specific ammo at specific targets, but does not apply weapon and ammo effects to those targets, is obviously a bug and should be fixed.