search

X2CommunityCore / X2WOTCCommunityHighlander

https://steamcommunity.com/workshop/filedetails/?id=1134256495
MIT License
60 stars 68 forks source link

Issue #1299 - remove unused local variable #1336

Closed Iridar closed 4 months ago

Iridar commented 4 months ago

Addendum for Issue #1299 - forgot to comment out the local variable RuptureCap which no longer has a use.

RustyDios commented 4 months ago

Other than the warning in the build for an unused variable this has potentially fatal knock-on effects for any classes that extend X2effect_applyweapondamage and expect to use/inherit the variable from the base class. It may be annoying to leave it in, but I would do so for the sake of Backwards Compatibility.

The Highlander is in a weird position where it can add stuff with ease, but caution is always advised for removing things.

[EDIT] : Ignore my comment, did not register to me it was a local variable, not a class one.