X2CommunityCore / X2WOTCCommunityHighlander

https://steamcommunity.com/workshop/filedetails/?id=1134256495
MIT License
60 stars 68 forks source link

Prevent rupture bonus damage from being added to attack that don't deal damage #1344

Closed Iridar closed 4 months ago

Iridar commented 4 months ago

Issue #1299

Addendum to #1330, which has removed the cap from bonus damage that can be applied to an attack by rupture, which was previously capped by the attack's base damage. This was deemed a bug, because Rupture's description says "adds +3 damage to following attacks", but in effect this can be +1 or +2 if the following attack did that much damage.

What has escaped the consideration is that the cap also prevented bonus damage from rupture from applying at all if the damage effect ended up doing zero damage.

Removing the cap allowed effects that normally don't do damage outside of specific circumstances, such as the Stock Miss Damage effect, to benefit from Rupture, even if the bonus damage from the Stock itself is not applied - because it was set to zero or because the weapon doesn't even have a stock equipped, presumably.