X2CommunityCore / X2WOTCCommunityHighlander

https://steamcommunity.com/workshop/filedetails/?id=1134256495
MIT License
60 stars 68 forks source link

Subsequent units with Solace do not get their passive immunity aura. #1353

Open Tedster59 opened 2 months ago

Tedster59 commented 2 months ago

If you have 2 or more Psi Operatives with Solace, all of them after the "first" one do not provide passive immunity.

The AOE immunity fires on UnitPostBeginPlay, and applies an effect to self + all allies.

image

However, the X2Effect_Solace effect is set to eDupe_Ignore, meaning that two copies of this effect cannot be assigned to units.

image

Tested with 2 psi operatives. Only mods used are Highlander, Yet Another F1, Show More Buff Details, Skirmish Mode+, and Extended Information to facilitate testing.

https://cdn.discordapp.com/attachments/646925416384299009/1252998149698486304/image.png?ex=667440f6&is=6672ef76&hm=83aa54f9d68c342e875dd1bc33c1338c7b973d30d1bfb548f8fd5b27f0a15a37&

First Psi Operative has Solace effect: https://cdn.discordapp.com/attachments/646925416384299009/1252998151028346990/image.png?ex=667440f6&is=6672ef76&hm=79e7e0608d59310558fd0649d230e15becb4bf77bccfa45096810a733cccda8d&

Second Psi Operative does not: https://cdn.discordapp.com/attachments/646925416384299009/1252998164307247164/image.png?ex=667440f9&is=6672ef79&hm=8b2ca17b13360cbc2e4e5a789a5bfdca9943a5ae05cc992a3b3664d63f57e693&

Moving second Psi Operative into Solace range of first Psi Operative activates the effect: https://cdn.discordapp.com/attachments/646925416384299009/1252998957915963413/image.png?ex=667441b7&is=6672f037&hm=743555c5f679f711a3c94289a47679df2cc0b4debd9f07f067b32adee6858c76&

Unit in range of second Psi Op does not receive Solace passive immunity: https://cdn.discordapp.com/attachments/646925416384299009/1252999180465471599/image.png?ex=667441ec&is=6672f06c&hm=5250ed60f6be47a9e10c164d96fe748d538de275340b2a7cf7ea25159bd4e4c7&

Same unit in range of first Psi Op does receive it: https://cdn.discordapp.com/attachments/646925416384299009/1252999272748683345/image.png?ex=66744202&is=6672f082&hm=2de12c8459918fb82c1605b0c471e9255039b065b223f1d69ad11e1383e8fe2d&

BlackDog86 commented 1 month ago

Can this be fixed just by adjusting the ability duplication (e.g. setting to eDupe_Refresh or eDupe_Allow)? Or will that have other un-intended consequences?

Iridar commented 1 month ago

Vanilla Solace needs to be taken outside and shot tbh