X2CommunityCore / X2WOTCCommunityHighlander

https://steamcommunity.com/workshop/filedetails/?id=1134256495
MIT License
60 stars 69 forks source link

REOPENED - Integrate Revival Protocol Fixes in CHL #1237 #1399

Open BlackDog86 opened 1 month ago

BlackDog86 commented 1 month ago

Fixes #1235

Reopening accidentally closed request.

Adds custom X2Condition to the RestoreActionPoints effect of Revival Protocol to prevent it from restoring APs to disoriented units. Updated the ability targetting condition to allow revival protocol to target stunned units, remove the stunned status and restore APs properly. Also integrated the additional targeting condition from RMs mod which allows the ability to target resistance soldiers. Discussion to be had over whether this part is required/necessary.

Still requires finessing & testing before merge.

Iridar commented 3 weeks ago

allows the ability to target resistance soldiers. Discussion to be had over whether this part is required/necessary.

In cases like this I would defer to in-game localization and reasonable player expectations.

Localization goes:

"Send the GREMLIN to an ally to remove any negative mental status effects: Disoriented, Stunned, Panicked, or Unconscious."

"an ally" would reasonably include any allied unit, including resistance soldiers.

The ability itself engages the GREMLIN to perform actions on a unit, requiring no special training or equipment from the unit, other than being human or close enough to a human (Skirmishers), so a reasonable person would expect it to be able to target resistance soldiers.

So I'd say yeah, valid change.

Iridar commented 3 weeks ago

This PR seems to be missing the .x2proj change with addition of new files.

BlackDog86 commented 3 days ago

This PR seems to be missing the .x2proj change with addition of new files.

Resolved :)

Iridar commented 18 hours ago

Sorry, but it needs to be in a separate commit.

BlackDog86 commented 13 hours ago

That should do it

BlackDog86 commented 10 hours ago

Updated the docs to be more descriptive and removed the errant /