search

X2CommunityCore / X2WOTCCommunityHighlander

https://steamcommunity.com/workshop/filedetails/?id=1134256495
MIT License
60 stars 69 forks source link

v1.18.0 skips Skyranger and other cutscenes #516

Closed ghost closed 5 years ago

ghost commented 5 years ago

Hi all,

First of all thanks for making this mod.

Apparently, v1.18.0 of the Highlander skips the Skyranger drop-in cutscenes and also skips the story-related cutscenes (like in the Lost & Abandoned mission).

Tested with a clean a install running only the Highlander. Attached is my launch.log: log.txt

Downgraded to v1.17.0 and did not experience this behavior.

Going off a hunch I think it's related to #395, but I ain't no expert.

Hope you will resolve this soon!

robojumper commented 5 years ago

Ah Christ, that looks like a missing return value that the the compiler doesn't warn about because it doesn't do any control flow analysis for returns. Opened #517 with the fix, will merge, build and upload shortly.

ghost commented 5 years ago

Thanks for the quick response and fix! You can close this issue whenever you feel it's resolved.

robojumper commented 5 years ago

The fix was merged and released as v1.18.1 on GitHub and the Steam workshop. Thanks for the report and for identifying the PR with the bug; Sorry about the issue. We are having a discussion about finding ways to improve our test coverage for future changes.