search

X2CommunityCore / X2WOTCCommunityHighlander

https://steamcommunity.com/workshop/filedetails/?id=1134256495
MIT License
60 stars 68 forks source link

Need event hook to handle doom being created by missions not on geoscape #550

Open jmartinez989 opened 5 years ago

jmartinez989 commented 5 years ago

There is a situation (specifically in Long War) where missions that generate doom (like alien facilities) can generate doom when not revealed. There is an issue with the current Highlander code that makes it so that doom is not properly updated when this happens.

An event based hook needs to be updated when the current doom of the alien HQ is acquired so that the doom from unrevealed events can be captured correctly.

jmartinez989 commented 5 years ago

I have an implementation of this. Just need to make a pull request.

Iridar commented 3 years ago

I wanted to add docs for this, but couldn't understand why it does what it does.

If the issue is with the doom not being updated when it should be, then shouldn't this implement an event listener that will force update doom when a specific event is triggered, and then have those LW missions or whatnot trigger that event to force update doom when they need to?

Instead, this issue triggers events to allow mods to override current doom. So mods can do what? Check if there is a hidden mission that has generated X additional doom up to this point? Seems backwards.