X2CommunityCore / X2WOTCCommunityHighlander

https://steamcommunity.com/workshop/filedetails/?id=1134256495
MIT License
60 stars 69 forks source link

Conventional weapon breakthrough interacts badly with Psi Amps #612

Open pledbrook opened 5 years ago

pledbrook commented 5 years ago

This actually affects any conventional weapon that ignores base damage. Basically the preview damage includes the breakthrough's +1 damage, but the actual application of that damage does not. So there's an inconsistency from the player's perspective.

The following LWOTC save demonstrates the problem:

save_BUG Soulfire preview incorrect.zip

Soulfire damage preview says it will do 5-7 damage, but in fact it will only do 4-6.

The offending code is in X2Effect_BonusWeaponDamage, which seems to deliberately treat the actual damage differently from the damage preview. There seems to be no valid reason for it to do so.

Xymanek commented 5 years ago

While the save isn't hugely relevant here, in future try to use vanilla (no mods, only CHL) saves as that makes it much easier to others to check them

Xymanek commented 5 years ago

A possibly relevant thing: in ABB (non-TLE) there is a perk that increases damage from secondary weapons and you can put psi amps on anyone as a secondary weapon. I tested the interaction and afaik it does increase the damage of null lance

MrNiceUK commented 5 years ago

Null Lance has bIgnoreBaseDamage set. More likely, that ability simply doesn't use X2Effect_BonusWeaponDamage.

Iridar commented 8 months ago

1284 that "fixed" this issue caused another bug and was reverted, so I'm reopening this issue.