search

X2CommunityCore / X2WOTCCommunityHighlander

https://steamcommunity.com/workshop/filedetails/?id=1134256495
MIT License
60 stars 69 forks source link

Intel Purchased Hack Rewards can repeatedly apply the effects of the Hack Reward to Units On Mission Start. #904

Open ReshiMael opened 4 years ago

ReshiMael commented 4 years ago

This bug mainly affects a few specific Hack Rewards, known Hack Rewards affected by this bug include: Override, and Squad Individual Concealment.

The number of times the bugged rewards can be applied to a unit appears to scale with squad size.

Xymanek commented 4 years ago

At this point, the repeated individual concealment (popup) is a feature, not a bug 😂

Iridar commented 3 years ago

I'm confused, what are "intel purchased" hack rewards? Are these the mission start bonuses you buy for the telecom tower mission on the Geoscape?

ReshiMael commented 3 years ago

For the vanilla telecom tower mission, yes, those mission start bonuses. It also applies to other implementations of the same mechanic. So if you implement the intel purchasable mission modifiers/hack rewards for other missions via mods, the same bugs that happen on that mission will carry over to any mods that use that mechanic.

What is not clear due to how small the mission squad and how few enemies there usually are on that mission, is that the game doesn't properly check to see if the bonus has been added, and seems to stack the bonus on every member of the squad as many times as you have squad members.

With some of the bonuses, for example, the squad gets squadsight bonus, it causes UI clutter by giving all members of the squad as many instances of the squad sight ability as there are squad members, and possibly other bugginess that I wasn't able to confirm.

With others, for example, the take no damage X number of times bonus, that also stacks instances on everyone equal to how many squad members you have. Mod added options/buffs to the pool of intel purchasable hack rewards/mission modifiers are also affected by this issue.

Edit: Forgot to mention that with some, it can just flat prevent you from playing for a significant amount of time, by just going to show a pop up on each soldier, cycling one instance of the stack at a time, cycling through every soldier until it has gone through the loop as many times as you have soldiers. It can also sometimes just get stuck in a loop doing this.