search

X2CommunityCore / xcom2-launcher

The Alternative Mod Launcher (AML) is a replacement for the default game launchers from XCOM 2 and XCOM Chimera Squad.
GNU General Public License v3.0
347 stars 51 forks source link

Cyrillic descriptions aren't updated correctly #280

Open EricKotato opened 2 years ago

EricKotato commented 2 years ago

AML Version: 1.5.0-beta, 1.5.0-beta.2

Description Even though #215 was resolved for Cyrillic mod titles, descriptions are still using wrong encoding until they're deleted and installed again.

Screenshots

Before unsubscribing, deleting mod entry, and subscribing again (title is fine, description is not):

After unsubscribing, deleting mod entry, and subscribing again (both title and description are fine):

RevZero commented 2 years ago

It is by design, that the description is not updated each time the mod is updated. The reasoning behind that is, that it is possible to edit the description (to leave a compatibility note or something) and you would not want to have it overwritten each time.

While the mod name can also be edited, it is implemented slightly different. AML remembers if the mod name has been manually edited. If not, it will be updated each time the mod is updated, otherwise the name will stay customized.

It would probably make sense to have the mod description behave similarly. But that would be kind of a breaking change, because AML would silently overwrite potentially edited mod descriptions.