Closed tster closed 2 years ago
I've managed to diagnose this error. The issue was having not having enough WETH for the offer in the wallet.
I think the error handling for this case should be improved, with the creation of a dedicated insufficient funds
error code.
Now for insufficient funds, the api will return 2014 error code.
Describe the bug When following the instructions to make an offer as described at https://github.com/X2Y2-io/x2y2-sdk#making-offers--collection-offers, an
Error: bad response
is thrown.Code sample
Expected behavior The API should return a 200 status code. If something is wrong with the order, one of the custom error codes should be thrown.