search

X9Developers / XSN

XSN - Stakenet, the first cryptocurrency with Trustless Proof of Stake
https://stakenet.io
MIT License
93 stars 49 forks source link

Test failure #161

Closed blockpete closed 3 years ago

blockpete commented 4 years ago

Key_io tests fail in Dockerfile build. Unable to build docker image

Succesfuly build docker image

test/key_io_tests.cpp(130): error: in "key_io_tests/key_io_valid_gen": check address == exp_bas e58string has failed [xc1qqqqqp399et2xygdj5xreqhjjvcmzhxw4aywxecjdzew6hylgvseswp80ag != bcrt1qq qqqp399et2xygdj5xreqhjjvcmzhxw4aywxecjdzew6hylgvseswlauz7] 21 failures are detected in the test module "XSN Test Suite" make[3]: [test/key_io_tests.cpp.test] Error 1 Makefile:11475: recipe for target 'test/key_io_tests.cpp.test' failed

docker build -t xsn .

master , releases v1.0.22 v1.0.23 v1.0.24

Docker version: 19.03.12 OS: Debian buster (10.6)

Adding --disable-tests to ./configure in Dockerfile makes the build run succesful.

AlexITC commented 4 years ago

I did tried building the image, which resulted in a failure as well:

*** 21 failures are detected in the test module "XSN Test Suite"
make[3]: *** [test/key_io_tests.cpp.test] Error 1
Makefile:11475: recipe for target 'test/key_io_tests.cpp.test' failed
make[3]: Leaving directory '/tmp/xsncore/src'
Makefile:11221: recipe for target 'check-am' failed
make[2]: *** [check-am] Error 2
make[2]: Leaving directory '/tmp/xsncore/src'
Makefile:10909: recipe for target 'check-recursive' failed
make[1]: Leaving directory '/tmp/xsncore/src'
make[1]: *** [check-recursive] Error 1
Makefile:751: recipe for target 'check-recursive' failed
make: *** [check-recursive] Error 1
The command '/bin/sh -c apt-get update     && apt-get upgrade -y     && apt-get install --no-install-recommends --no-install-suggests -y         apt-utils         curl         g++         make         automake         pkg-config         doxygen         bsdmainutils         libtool         libdb++-dev         libboost-system-dev         libboost-filesystem-dev         libboost-chrono-dev         libboost-program-options-dev         libboost-test-dev         libboost-thread-dev         libssl-dev         libevent-dev     && curl -kL $PKG_URL.tar.gz | tar -xz -C /tmp     && cd /tmp/$BERKELEYDB_VERSION/build_unix     && ../dist/configure --enable-cxx --includedir=/usr/include/bdb4.8 --libdir=/usr/lib     && sed s/__atomic_compare_exchange/__atomic_compare_exchange_db/g -i /tmp/$BERKELEYDB_VERSION/dbinc/atomic.h     && make -j$(nproc)     && make install     && cd /tmp/xsncore     && ./autogen.sh     && ./configure --without-gui --prefix=/usr     && make -j$(nproc)     && make check     && make install     && apt-get purge -y         apt-utils         curl         g++         make         automake         pkg-config         doxygen         bsdmainutils         libtool         libdb++-dev         libboost-system-dev         libboost-filesystem-dev         libboost-chrono-dev         libboost-program-options-dev         libboost-test-dev         libboost-thread-dev         libssl-dev         libevent-dev' returned a non-zero code: 2
blockpete commented 3 years ago

Please note that I the docker image can be build baed om debian-buster:slim. But with tests disabled however. This produces a stable running xsn docker container.

blockpete commented 3 years ago

I therefore close the issue.. If anyone feels the code modifications I did are useful I can always create a pull request.