search

XAI-ANITI / ethik

:mag_right: A toolbox for fair and explainable machine learning
https://xai-aniti.github.io/ethik/
GNU General Public License v3.0
52 stars 5 forks source link

Rename bias into influence #93

Closed Vayel closed 4 years ago

Vayel commented 4 years ago

@MaxHalford do you remember why we replaced explain_predictions() with explain_bias()?

In theory, it should be explain_influence_on_predictions/performance() but it's a bit long. Maybe we can just use explain_predictions()? But since we gave up this name, I guess we had a good reason.

MaxHalford commented 4 years ago

I think I just gave my "biased" opinion and didn't like explain_predictions :). I really like explain_influence though.

Vayel commented 4 years ago

I like it as well, but it doesn't tell use what the influence is on. Would you call the methods explain_influence and explain_performance?

MaxHalford commented 4 years ago

Maybe it's just me but I find that explain_influence is enough informative. I think it's pretty obvious that the influence we're hinting at is between the features and the target, which is why users are using the package in the first place. This is Python, not C# :). explain_performance seems good to me.

Vayel commented 4 years ago

What I mean is that explain_performance is also the explanation of an influence (on the performance). But I'm ok with using explain_influence for the predictions.

MaxHalford commented 4 years ago

Ah, I see what you mean... I'll have a think about it.