Have Loader::lookup_complete return Option<String>

XAMPPRocky / fluent-templates

Easily add Fluent to your Rust project.

Apache License 2.0

136 stars 28 forks source link

Have Loader::lookup_complete return Option<String> #32

Closed jamolnng closed 2 years ago

jamolnng commented 2 years ago

Having Loader::lookup_complete and subsequently lookup_with_args and lookup will let the user choose what to do in case the fluent template is not found with the given language identifier or the fallback identifier

XAMPPRocky commented 2 years ago

Thank you for your issue! Seems reasonable to me, if someone wants to contribute a PR to fix it, it's always welcome.

jamolnng commented 2 years ago

will work on it, seems like a quick change

jamolnng commented 2 years ago

Closed https://github.com/XAMPPRocky/fluent-templates/pull/33