search

XAMPPRocky / fluent-templates

Easily add Fluent to your Rust project.
Apache License 2.0
136 stars 28 forks source link

remove snafu #60

Closed burrbull closed 5 months ago

XAMPPRocky commented 5 months ago

Thank you for your PR, and congrats on your first contribution! 🎉

torokati44 commented 5 months ago

BTW This PR bumped the flume dependency to 0.11.0 in the main crate, but not in macros, thereby causing a version duplication of it: https://github.com/ruffle-rs/ruffle/actions/runs/8701668584/job/23864127408#step:5:589

You could consider setting up the common dependencies as workspace level ones, a la: https://github.com/ruffle-rs/ruffle/pull/15868

XAMPPRocky commented 5 months ago

Yes we should, PR doing so are welcome this crate was made before that feature existed.

torokati44 commented 5 months ago

There you go: https://github.com/XAMPPRocky/fluent-templates/pull/64