XAMPPRocky / fluent-templates

Easily add Fluent to your Rust project.
Apache License 2.0
136 stars 28 forks source link

Fix: Add follow_links to support builds with Bazel #62

Closed dorezyuk closed 5 months ago

dorezyuk commented 5 months ago

Bazel symlinks every file - Currently the is_file would return false (and is_symlink would return true). I've added follow_link so is_file returns the metadata of the dir entry where the sym link is pointing to.

Let me know if you need a minimal reproducible example or something like that.

Also I did not test it with walkdir (I'm not sure what the state here is since there is no walkdir feature in Cargo.toml )

XAMPPRocky commented 5 months ago

Thank you for your PR!

Also I did not test it with walkdir (I'm not sure what the state here is since there is no walkdir feature in Cargo.toml )

It's an optional dependency so there automatically is a feature created called walkdir.

dorezyuk commented 5 months ago

It's an optional dependency so there automatically is a feature created called walkdir.

Understood, tested it with features = ["walkdir", "tera", "macros"], default-featres = false }

XAMPPRocky commented 5 months ago

Thank you for your PR, and congrats on your first contribution! 🎉