Added tests for `repos().merges()`

XAMPPRocky / octocrab

A modern, extensible GitHub API Client for Rust.

Other

1.1k stars 265 forks source link

Added tests for `repos().merges()` #560

Closed manchicken closed 9 months ago

manchicken commented 9 months ago

Added a test for 201 cases
Added a test for 204 cases
Fixed the broken 204 case

BREAKING CHANGE WARNING: This changes the return type of the builder from Result<models::repos::MergeCommit> to Result<Option<models::repos::MergeCommit>>.

manchicken commented 9 months ago

I do think that this is the cleanest approach to this problem, but I don't like introducing breaking changes.

XAMPPRocky commented 9 months ago

Thank you for your PR!