compilation failure with `default-features = false`

hdonnay commented 6 months ago

I have the (admittedly slightly odd) use case where I'm only using this crate for its types. The latest version doesn't build with default-features = false.

The first error seems to be leftover from the hyper 1 update, as it's conditional on omitting tls support.

The second seems to because the tokio feature is not toggled on for thehyper_util usage.

   Updating crates.io index
   Compiling octocrab v0.34.1
error[E0432]: unresolved import `hyper::client::HttpConnector`
   --> /var/home/hank/.cargo/registry/src/index.crates.io-6f17d22bba15001f/octocrab-0.34.1/src/lib.rs:209:5
    |
209 | use hyper::client::HttpConnector;
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `HttpConnector` in `client`

error[E0433]: failed to resolve: could not find `TokioExecutor` in `rt`
   --> /var/home/hank/.cargo/registry/src/index.crates.io-6f17d22bba15001f/octocrab-0.34.1/src/lib.rs:621:73
    |
621 |             hyper_util::client::legacy::Client::builder(hyper_util::rt::TokioExecutor::new())
    |                                                                         ^^^^^^^^^^^^^ could not find `TokioExecutor` in `rt`

hdonnay commented 5 months ago

Seems to be fixed with 26dfe07

Sytten commented 1 week ago

It is broken right now

XAMPPRocky / octocrab

compilation failure with `default-features = false` #583