search

XAMPPRocky / octocrab

A modern, extensible GitHub API Client for Rust.
Other
1.06k stars 258 forks source link

docs: Update manual github app authentication example #610

Closed timonv closed 5 months ago

timonv commented 5 months ago

When manually doing requests with octocrab, tokens are not forwarded to urls that contain an authority. This PR updates the example to reflect that requirement.

Edit: makes sure the the documentation aligns with #576. Personally not against the current implementation, although the error could be better.

timonv commented 5 months ago

My bad, assumed it was correct because because analyzer was not complaining :shrug:

XAMPPRocky commented 5 months ago

Thank you for your PR, and congrats on your first contribution! 🎉