search

XAMPPRocky / octocrab

A modern, extensible GitHub API Client for Rust.
Other
1.07k stars 261 forks source link

Change `Rate::reset` to `u64` #615

Closed smoelius closed 6 months ago

smoelius commented 6 months ago

Fixes #614

XAMPPRocky commented 6 months ago

Thank you for your PR!

XAMPPRocky commented 6 months ago

Though looking at this, probably all the fields should not be usize.

smoelius commented 6 months ago

Though looking at this, probably all the fields should not be usize.

I'm not sure, TBH. But since the the other fields are counts of "actions," usize seems reasonable.

XAMPPRocky commented 6 months ago

Generally if it doesn't actually match to the size of a machine pointer, it shouldn't use the size types, it should be u32 or u64.