field 'author' and 'committer' of type 'RepoCommitPage' are wrong

XAMPPRocky / octocrab

A modern, extensible GitHub API Client for Rust.

Other

1.02k stars 253 forks source link

field 'author' and 'committer' of type 'RepoCommitPage' are wrong #635

Closed havontuur closed 1 month ago

havontuur commented 2 months ago

The fields 'author' and 'committer' should be of type 'CommitAuthor' instead of 'GitUserTime'.

pub struct RepoCommitPage { pub url: Url, pub author: Option<CommitAuthor>, pub committer: Option<CommitAuthor>, pub message: String, pub comment_count: u64, pub tree: CommitObject,

#[serde(skip_serializing_if = "Option::is_none")]
pub verification: Option<Verification>,

}

maflcko commented 1 month ago

This was fixed and can be closed?