search

XAMPPRocky / octocrab

A modern, extensible GitHub API Client for Rust.
Other
1.02k stars 253 forks source link

Return result instead of panic when returning an `installation` Octocrab instance #641

Open krishmas opened 2 months ago

krishmas commented 2 months ago

https://github.com/XAMPPRocky/octocrab/blob/7e280be901c378a1e162c37f909ea6590c6ff4ba/src/lib.rs#L981

Would be nicer to return an Error result (like other functions that return different types of Octocrabs do) instead of panicking so the application using doesn't immediately crash out

XAMPPRocky commented 2 months ago

Thank you for your issue! A PR adding this would be welcome 🙂