Finish webapp

[NormalDuck]

This pull request has a working production build in my fork and adds manual page, fixes leaderboard, browser issues and most eslint errors

The visuals are still quite ugly and doesn't have a pleasant user experience

[NormalDuck]

Issues mentioned in https://github.com/XBOT-FTC/FTC-Scouting-App/issues/61 https://github.com/XBOT-FTC/FTC-Scouting-App/issues/59 are not resolved in this pull request

[NormalDuck]

Leaderboard not showing when filtered by "minimum". All entries are 0 when trying to view the minimum scores.

No data is shown when you select minimum filter is intentional. Because this filter finds the lowest score, and we didn't finish scouting all the matches. So all team's minimum score is expected to be 0

---

No navigation bar to return to the dashboard page without having to input the name again.

Mentioned in the github issue. Will fix it in the next pull request

---

Add checks to be sure that a match number and team name is selected before they can "continue".

Will fix that in this pull request

[johnylamw]

A minor concern is the way you're calculating the data in the "leaderboards" page in which you take the average of all the matches including the matches that aren't scouted yet (which are left as zeros in the data). However, this wouldn't be an accurate representation of the robot's capabilities if our drive team is using it during the qualification matches to measure the strength of their team and the opponent team.

Ex: Only 1 match is played where 3231 scored 6 specimens, however, since there are 5 more matches to be played, the average computes to one 1 specimen which significantly weakens the view that 3231 can score 6 specimens per match. This might devalue who we view other teams in coming up with a strategy during the game.

Are you able to compute the calculations based on the matches scouted? You can either sort through the list and add up all the instances of 'scouted' or store a separate data in TeamProperties that you can update after every scouted match.

[johnylamw]

Leaderboard not showing when filtered by "minimum". All entries are 0 when trying to view the minimum scores.

No data is shown when you select minimum filter is intentional. Because this filter finds the lowest score, and we didn't finish scouting all the matches. So all team's minimum score is expected to be 0

Are you filtering by the lowest score of a given match or overall average "lowest" score?

[NormalDuck]

Are you able to compute the calculations based on the matches scouted?

Yes, thats possible. I have a field called scouted. I can choose to ignore the unscouted matches to make the average less polluted during qualification matches

[johnylamw]

Oh right, nevermind. I got confused for a second on the maximum and minimum thingy..

[johnylamw]

Great work though! Good to see the scouting app getting put together. I might have more requests that needs to be added but I'll need to think about it.

[johnylamw]

I'm happy to approve this once you address the match selection continue issue then you can work on another PR so it doesn't get too messy.

[johnylamw]

Also, if you return to the alliance page (by clicking on the home icon), the state of the select is preserved (underlying logic) even though the text is reverted back to the original "Match Number" and "Team Number"

-

Probably need to add some onChange to flush it out and perhaps add some conditions to <Link href={"/auto"}> Continue</Link> for it to not route to /auto if nothing is selected. For example, link to /auto only if there is a cursor and match number, otherwise, it only routes to itself? There are other ways you can do it though

[NormalDuck]

@johnylamw The issue has been fixed

[NormalDuck]

I have been noticing the glitch/bug you have addressed. I couldn't find a solution to it so I gave up since I can assume scouters wont sabotage that bug to mess up the data hopefully