Closed mlep closed 4 years ago
What is the URL for the most recent version? Once you have that URL, it's a simple matter of opening a PR, which you can do the following way:
After this you're a contributor and know how to contribute code/stuff on GitHub!
Thanks for the detailed explanation. So, the main issue is about the URL... The current version is on a google drive: https://drive.google.com/file/d/1RbG6aIQThAYs5EcUOJF1bPG7QfQXbrd1/view
Thanks for checking. Not too happy about Google Drive being involved, but it is what it is unless someone knows a better place to get the file.
The direct download URL for the file is: https://drive.google.com/uc?export=download&id=1RbG6aIQThAYs5EcUOJF1bPG7QfQXbrd1
I got that URL by using https://sites.google.com/site/gdocs2direct/ but one can just edit the URL manually otherwise.
Can you try to file a PR with that URL (don't forget to update the date as well)?
OK, I will do this. Nice trick to get the direct download URL!
Argh.. google drive for something as vital and important as this. Can you motivate the FFVP to provide an official download link on a serious server? They get enough money from me every year.
My experience with dropbox and google drive links is that they expire and die.
An option is to host it with http://soaringweb.org. Send the updated file to john leibacher.
Then we can link to it with a stable service.
Why not send it to the place that hosts the currently used file instead, http://soaring.gahsys.com/Airspace/HomePage.html (john.leibacher@gmail.com)?
I will create a PR to update the file https://github.com/XCSoar/xcsoar-data-repository/blob/master/data/airspace.json when needed.
Yeah, that's great, let's put this issue on hold until we get a better URL to use :) Nice work!
Prompt reply from the FFVP airspace commission:
Hopeless...
And prompt reply from John L.: he will upload the file ASAP. I will take care of the file airspace.json afterward.
Nice work @mlep, well done. Was this your first PR?
@rawtaz. Thanks. No, it was not (I do not contribute code, but documentation, translation, etc.)
Ah, well then, I didn't mean to suggest you were a beginner, I just assumed you hadn't made PRs before. Sorry about that, and thanks again!
@rawtaz No offense! Cheers.
I have just updated the French airspace for XCSoar, using its download feature. The header of the file shows this version is one year old:
The French soaring federation (FFVP) currently hosts a much recent version:
Looking at the file https://github.com/XCSoar/xcsoar-data-repository/blob/master/data/airspace.json , I notice the French airspace comes from the URL: http://soaring.gahsys.com/Airspace/FR/190523__AIRSPACE_FRANCE_2019-05.txt
How to make the most recent FFVP airspace file available to all XCSoar's users?