XCSoar / xcsoar-data-repository

XCSoar File Manager Data Repository
https://download.xcsoar.org/repository
8 stars 23 forks source link

French airspace outdated #151

Closed mlep closed 4 years ago

mlep commented 4 years ago

I have just updated the French airspace for XCSoar, using its download feature. The header of the file shows this version is one year old:

*                        SOURCE: AIP FRANCE 2019/05/23                         *
*                               Version 2019-05                                *
*                           Fichier crée 23 mai 2019  

The French soaring federation (FFVP) currently hosts a much recent version:

*                        SOURCE: AIP FRANCE 2020/04/23                      *

Looking at the file https://github.com/XCSoar/xcsoar-data-repository/blob/master/data/airspace.json , I notice the French airspace comes from the URL: http://soaring.gahsys.com/Airspace/FR/190523__AIRSPACE_FRANCE_2019-05.txt

How to make the most recent FFVP airspace file available to all XCSoar's users?

rawtaz commented 4 years ago

What is the URL for the most recent version? Once you have that URL, it's a simple matter of opening a PR, which you can do the following way:

After this you're a contributor and know how to contribute code/stuff on GitHub!

mlep commented 4 years ago

Thanks for the detailed explanation. So, the main issue is about the URL... The current version is on a google drive: https://drive.google.com/file/d/1RbG6aIQThAYs5EcUOJF1bPG7QfQXbrd1/view

rawtaz commented 4 years ago

Thanks for checking. Not too happy about Google Drive being involved, but it is what it is unless someone knows a better place to get the file.

The direct download URL for the file is: https://drive.google.com/uc?export=download&id=1RbG6aIQThAYs5EcUOJF1bPG7QfQXbrd1

I got that URL by using https://sites.google.com/site/gdocs2direct/ but one can just edit the URL manually otherwise.

Can you try to file a PR with that URL (don't forget to update the date as well)?

mlep commented 4 years ago

OK, I will do this. Nice trick to get the direct download URL!

lordfolken commented 4 years ago

Argh.. google drive for something as vital and important as this. Can you motivate the FFVP to provide an official download link on a serious server? They get enough money from me every year.

My experience with dropbox and google drive links is that they expire and die.

An option is to host it with http://soaringweb.org. Send the updated file to john leibacher.

Then we can link to it with a stable service.

rawtaz commented 4 years ago

Why not send it to the place that hosts the currently used file instead, http://soaring.gahsys.com/Airspace/HomePage.html (john.leibacher@gmail.com)?

mlep commented 4 years ago
mlep commented 4 years ago

I will create a PR to update the file https://github.com/XCSoar/xcsoar-data-repository/blob/master/data/airspace.json when needed.

rawtaz commented 4 years ago

Yeah, that's great, let's put this issue on hold until we get a better URL to use :) Nice work!

mlep commented 4 years ago

Prompt reply from the FFVP airspace commission:

Hopeless...

mlep commented 4 years ago

And prompt reply from John L.: he will upload the file ASAP. I will take care of the file airspace.json afterward.

rawtaz commented 4 years ago

Nice work @mlep, well done. Was this your first PR?

mlep commented 4 years ago

@rawtaz. Thanks. No, it was not (I do not contribute code, but documentation, translation, etc.)

rawtaz commented 4 years ago

Ah, well then, I didn't mean to suggest you were a beginner, I just assumed you hadn't made PRs before. Sorry about that, and thanks again!

mlep commented 4 years ago

@rawtaz No offense! Cheers.