XCTEQ / fastlane-plugin-altool

Fastlane plugin to upload ipa files to iTunes Connect using alto
MIT License
29 stars 13 forks source link

altool fails when ipa path contains a space #4

Open meehanman opened 5 years ago

meehanman commented 5 years ago

When using the following fastfile (ionic). My app path has a space which causes altool to fail.

ionic(
    provisioning_profile:ENV["sigh_"+AppBundleId+"_appstore"],
    platform:"ios",
    prod: true,
    device: true,
    release: true
)
altool(
    altool_app_type:"ios",
    altool_ipa_path: ENV['CORDOVA_IOS_RELEASE_BUILD_PATH']
)

Altool command:

/Applications/Xcode.app/Contents/Applications/Application\ Loader.app/Contents/Frameworks/ITunesSoftwareService.framework/Support/altool --upload-app -t ios -f /Users/teamcity/Repos/MobileApps/MobileApp/platforms/ios/build/device/MyApp Name.ipa -u **************** -p *****************--output-format normal

Error Message:

Error Domain=ITunesSoftwareServiceErrorDomain Code=-19066 \"The path '/Users/teamcity/Repos/MobileApps/MobileApp/platforms/ios/build/device/MyApp' does not contain a file.\" UserInfo={NSLocalizedDescription=The path '/Users/teamcity/Repos/MobileApps/MobileApp/platforms/ios/build/device/MyApp' does not contain a file., NSLocalizedFailureReason=Unable to validate your application.}"

This is due to the app file location not being wrapped in quotes when passed into the commandline

Shashikant86 commented 5 years ago

Hey @meehanman Sorry for the terrible delay in merging this PR. I have merged it now and will push new version soon!

meehanman commented 5 years ago

Cheers @Shashikant86. I was able to use my own repo for Fastlane easily enough.