search

XCTEQ / fastlane-plugin-altool

Fastlane plugin to upload ipa files to iTunes Connect using alto
MIT License
29 stars 13 forks source link

Prefixes in option names are redundant? #7

Open mgrebenets opened 5 years ago

mgrebenets commented 5 years ago

I think prefixing each option name with altool_ is redundant. It's already clear that these options are for altool action, so instead of

    altool(
        altool_username: ENV["FASTLANE_USER"],
        altool_password: ENV["FASTLANE_PASSWORD"],
        altool_app_type: "ios",
        altool_ipa_path: "./build/Your-ipa.ipa",
        altool_output_format: "xml",
    )

It should rather be:

    altool(
        username: ENV["FASTLANE_USER"],
        password: ENV["FASTLANE_PASSWORD"],
        app_type: "ios",
        ipa_path: "./build/Your-ipa.ipa",
        output_format: "xml",
    )

This will also make this plugin aligned with other Fastlane actions and plugins