search

XCompWiz / LookingGlass

Extra-Dimensional Viewer API mod for Minecraft
Other
34 stars 8 forks source link

Fixed block particle duplication bug #24

Open Geforce132 opened 8 years ago

Geforce132 commented 8 years ago

This fixes the block-breaking duplication bug that occurs when there is a view in the same dimension as the player.

XCompWiz commented 8 years ago

Looks good! :D Are there any side effect to removing and readding the renderer every frame? I think there is logic to detect the "main world" changing. Wouldn't it be more practical to only do this on that change?

Geforce132 commented 8 years ago

Ah, yeah, that would be better, lol.

What was the logic you were thinking of? I can hopefully test it out.

XCompWiz commented 8 years ago

It's been a year, nearly, so I don't remember the exact location or if it is still in, but I recall a section of code detecting Overworld world changes (by comparison) and handling world changes somewhere. I feel the detection was probably in the ProxyWorldManager, though I think the handling was called from there and somewhere else. You shouldn't have to look far from this class, really.