XCompWiz
commented
7 years ago Well there's a fun border case. :D
I might implement your suggestion, but it isn't a perfect fix. It just defers the problem (potentially enough that it wouldn't matter, but the border case would remain).
The catch for your solution is I would need to merge in any added pages, which at even 1k entries could take a moment computationally.
It's also worth noting that page quality is coming; that will both make this issue easier to hit and make the proposed solution less effective.
I'll have to think about clever ways to solve this. No matter what I might need to apply a hard limit to the number of items that can be stored in the portfolio as an actual "fix."
KlutzLament
EyeDeck
So in this particular instance 385 tags + 56 duplicate tags is 441, and at an average length of 60 bytes, this would reduce the overall data length from ~800KB to ~26KB. Here we're only looking at a factor-of-30 or so decrease, but even if one were to triple the page count to 45,000, since all but a small percentage of pages would still fit within their original tag, total size would only increase slightly (~33KB). As noted before, it would be somewhere over 1 million semi-randomly assorted pages (as would drop from sealed notebooks) before NBT size became an issue again.
DwellerBenthos
Short backstory, I was hunting for a Chromaticraft "Dense Generation" page for quite some time, and Reika set the drop chance on that page very, very low. Lots of exploration, a villager spawner (feeding into a TiCon smeltery) and several hundred sealed notebooks later, I was disconnected with an error typical of an item with an NBT tag waaay too big, and attempting to reconnect gives me similar errors, e.g;
I checked the player save file with the portfolio that disconnected me, and found this:
That's one entry for every individual page, not just page type. Unsurprisingly, 15,000 of these entries exceeded the 1MB-per-item limit that the game engine imposes.
I assume it'll take some reworking of the interface to accomplish this, but the immediate solution that comes to mind is to rewrite it more like a chest, e.g. store 127 pages per type per NBT entry (the count tag that already exists is a byte), and only after that's full make a new one. The interface already tallies page counts greater than 1 correctly, though withdrawing stops working when it gets to a non-1-count page, and obviously insertion currently splits stacks into individual tags.
Also, here's the player save that was giving me trouble: 51742687-d54a-431b-b54e-8b10505afc52.zip I solved the problem by loading the save in NBTExplorer, and splitting half of the pages in the portfolio off into another empty portfolio that had already been in my inventory, then reloading the save.