XCompWiz / Mystcraft-Issues

Issue tracked and localization repo for the MInecraft mod Mystcraft
xcompwiz.com
31 stars 22 forks source link

[1.11.2] Chunk population, causing cascading worldgen lag and log spam #188

Open cragrim opened 7 years ago

cragrim commented 7 years ago

I'm was really happy to see an update to Mystcraft for 1.11.2 being one of my all time favorite mods :) So BIG thanks for getting back to it XCompWiz!! <3

Unfortunately I ran into a bit of a lag issue. I haven't crashed yet but looking at the log it's being spammed something insanely. I'm running a lot of other mods so it might be caused due to interacting with them. I havent tried removing chisel and forestry yet.

This happens even when the overworld is not world genning so maybe its some other dimension trying to load chunks? Maybe extrautilities2 Quantum quarry mining dimension? I'm not sure.

Basically this spams this about 4-20 times every second into the log:

Log uploaded using MultiMC: https://paste.ee/p/sp4PE (the whole thing is too big, it grew to several MB in just a minute)

Mod list using /dir in mod folder https://paste.ee/p/7oGpq

Forge version: forge-1.11.2-13.20.1.2391-installer.jar

I will add more info here later as I find out more.

cragrim commented 7 years ago

Probably same issue as the following issues. Sorry for not checking before I posted. https://github.com/XCompWiz/Mystcraft-Issues/issues/186 https://github.com/XCompWiz/Mystcraft-Issues/issues/182 https://github.com/XCompWiz/Mystcraft-Issues/issues/180

cragrim commented 7 years ago

Breaking blocks has a lag delay of about 1-10 seconds and accessing machines can take 5-30 seconds.

cragrim commented 7 years ago

I removed Forestry and Chisel which were spouting the errors along with Mystcraft and the lag has been reduced substantially. Still get occasional 1-2 second blocklag.

New log without Forestry and Chisel: https://paste.ee/p/9608D

XCompWiz commented 7 years ago

Thanks! Glad you like it, and glad we could get it back up and running.

During the baselining phase there is a chunk generated every 5 ticks. Depending on your mod configuration this can be laggy. Lots of mods add to world gen and can slow it down. Mystcraft tries to keep it as fast as it can within its own mechanics. For 1.11, it's hands are a bit more tied, sadly, so it lost a little of the speed gain it had over vanilla.

The cascading that is happening during the baselining is actually standard vanilla generation cascades. Forge ignores those, usually, but since Mystcraft is triggering the chunk generation during its event processing it gets attributed to Mystcraft instead of vanilla. (Most of the time I see it in testing, it's lakes.)

As to the lag and duration of the baselining, I'm working on changes that should improve this significantly. At the very least, it will only use biomes common to the overworld and should generate far fewer chunks overall.

Sunconure11 commented 7 years ago

https://gist.github.com/Sunconure11/373b1363c86cbba3be6e1d13adf44599

Probably related. Still am having lag on the latest version.

XCompWiz commented 7 years ago

HellFire has noted some additional issues with the profiling generation and corrected them. This should improve significantly (again!) in the next release. Particularly in the context of cascades.

IndigoAvemour commented 7 years ago

I'm glad I did a bit of digging and found this issue instead of just opening a new one. I'm glad to hear it's being worked on; I'm stuck in an endless and soulless void and can't get out!

So far, it's only given me one crash (https://pastebin.com/pfxuQHCD); otherwise, like the others who have posted here, I get bad log spam and chunk population and the like. In addition, when clicking "Save and Exit World" Minecraft freezes and has to be forcibly closed, if that's relevant ahah.

And for real though, I'm really happy you and the others have been working on Mystcraft again. I'm very much not a tech-mod person so RF Dimensions wouldn't do, so from 1.8 until now I've had nothing like it, something I enjoyed immensely in 1.7.10. Mystcraft being on 1.11.2 has legitimately renewed my enjoyment and interest in Minecraft in general. Take your time working on these things if you need to. You're providing this for free, after all! Thank you! I'm just happy the mod is being worked on. 😄

Novocastrian commented 7 years ago

Hi there!

I am also experiencing this issue in 1.11.2. To my understanding, I can just leave the world open and AFK it for a bit until minecraft sorts through the chunkloading?

Darkmega18 commented 6 years ago

So I have this in 1.12.2 now. as Xcomp says it is probably lakes, cause my random age happened to be a relatively tame landscape made entirely of end stone with a patchy netherrack ceiling over some areas with lava lakes. it's all peachy if I stand still and let stuff gen in. But while I've moving around even in what should be already genned locales of this age it lags when loading the chunks and indeed is still spamming me full of the very similar cascades from the top of this issue when new chunks are made.

it only lags profusely when I'm in an age tho. I managed to just gradually 10 frames per 6 seconds myself into a nearby star fissure back to the overworld and my RAM immediately cleared up from being capped off and I'm back to normal.

I'm going to see what turning off this profiler and tweaking some of the settings in the config may do for me, since I don't know why this profiler needs to be running literally every time I start my game after it's run once for a pack that otherwise shouldn't change much as far as content goes anymore. it takes a while to complete too. :v

ghost commented 4 years ago

Exactly the same problem still occurs, 1.12.2, as of writing latest version.