Open Sheldenburg opened 7 months ago
@Sheldenburg You can see we use options.method as the method. Does this not work for you?
@Sheldenburg You can see we use options.method as the method. Does this not work for you?
Yes, it does. But in the type definition, you also have 'method' outside of options. This one has never got used.
options: { url: 'http://127.0.0.1:8000/chat', method: 'POST', headers:{ 'Accept': 'application/json' }, body: { 'query': 'Hello! how are you' } }, method: { type: 'body', key: 'query' }, }
Hi, Thanks for creating this repo! Very useful for any react Chat interface. I found the method parameter seems a bit redundant. In the example code, you have something like this below.
options: { url: 'http://127.0.0.1:8000/chat', method: 'POST', headers:{ 'Accept': 'application/json' }, body: { 'query': 'Hello! how are you' } }, method: { type: 'body', key: 'query' }, }
However, in the getStream function below, only the 'options' parameter is used.
export const getStream = async (input: string, options: UseChatStreamHttpOptions, method: UseChatStreamInputMethod) => { options = mergeInputInOptions(input, options, method);
const params = '?' + new URLSearchParams(options.query).toString();
const response = await fetch(options.url + params, { method: options.method, headers: { ...DEFAULT_HEADERS, ...options.headers }, body: JSON.stringify(options.body, (_k, v) => v === null ? undefined : v) });
if (!response.ok) throw new Error(response.statusText);
return response.body; };