search

XDGFX / ultrasonics

Sync music playlists between all your music services. Do more with your music.
GNU General Public License v3.0
218 stars 18 forks source link

Support .flac/.ape format in the future? #18

Closed vindevil closed 2 years ago

vindevil commented 3 years ago

Plex failed importing playlist for most of my music files are stored in .flac or .ape format.

However, the online sync service Soundiiz does transfer playlist into Plex successfully with the same music library.

So I think maybe there is a chance that Ultrasonics could recognize .flac/.ape files in the future? Thanks.

vindevil commented 3 years ago

Today I found another project on Github can recognize .flac files and import Spotify playlist into Plex.

Hope this will benefit this project a bit.

XDGFX commented 3 years ago

Thanks for the feedback! I have been very busy with uni so haven't had the chance to expand functionality recently.

I am planning on adding .flac support for 1.1.0. I have actually added it already in the 1.1.0 branch, however I haven't tested it at all yet so can't promise it works 😉

Not sure about .ape, it looks like the module I'm using, mutagen, does support it so I'll look into it when I get some time.

vindevil commented 3 years ago

Very glad to hear that. Currently I can deal with it by using the other project metioned above. Please keep focusing on your uni and I will come back later to check if I'm lucky enough.

nisegami commented 3 years ago

Any progress on this issue? If testing is your concern I'd be down to try it out. Thanks!

XDGFX commented 3 years ago

I've just updated the 1.1.0 branch to include changes made on the master branch. #28

If you're up for testing it with a few flac files to make sure it's working as intended that would be great!

Easiest way would likely be putting breakpoints at the .flac part of the plugin here

If you could verify that it successfully reads all the fields and artists from a few different files I'll update the master branch!

nisegami commented 3 years ago

So I actually ended up doing a fork and cherry-picking 184cc7db94492e3fc99616db3a3e34c7ee33375a into master then building a local Docker image. I believe my FLAC tracks are being picked up now, but it's still a mismatch on the total number of tracks on my main playlist (local: 1528, Plex: 1476, local FLAC: 360) so let me do some more testing and get back to you.

nisegami commented 2 years ago

Reporting back. The FLAC fix seems to work fine. The # of files loaded mismatch seems to be an unrelated issue (it affects both FLAC and MP3 files, don't have a ton of M4A but none of the few I do have are affected), I'm investigating that further but I will file another issue for that if necessary.

Edit: just saw you added some extra logging to the 1.1.0 branch. will try it with that and report back.

Edit 2: no additional Plex log entries generated, but I think I'll give this another try before I rule it out completely. Either way, FLAC support seems good to go to me.

XDGFX commented 2 years ago

Awesome thanks for the feedback! I'll close this issue as it seems .flac is working for the next release, and I don't have immediate plans to support .ape (although PRs are welcome!).

samplethief commented 2 years ago

Hey buddy is flac supported now?

It still says on the applet creation screen that "⚠️ Only .m3u extensions are supported for playlists, and .mp3, m4a extensions are supported for audio files. Unsupported files will be ignored."

But messages in this thread seem to indicate otherwise?