USWDS Assets - Githubissues

XDgov / data-design-standards

Other

8 stars 3 forks source link

USWDS Assets #2

Closed s2t2 closed 6 years ago

s2t2 commented 6 years ago

Additions:

Top-level assets directory (follows rails asset directory naming conventions, but I'm happy to rename these directories as desired, really I have no preference here, let me know!)
Includes USWDS v1.4.2 assets downloaded from source
Index page with minimum content, styled and modeled after the USWDS docsite home page

lukad03 commented 6 years ago

@s2t2 Ready for your review. To better understand how to best organize USWDS asset files, I felt a Jekyll installation was needed to provide context. It forced me to reorganize the USWDS assets into a more Jekyll-friendly structure. I could have created a separate PR that initialized Jekyll but felt this would be acceptable at this stage in the project.

s2t2 commented 6 years ago

I'm concerned about our ability to upgrade the USWDS assets if they are mixed in with other assets like this. But if that issue emerges in the future, we can address it at that time.

Otherwise, OK to merge after adding the HTTPs-related "Here's how you know" content we discussed.