search

XENON1T / hax

Handy Analysis for XENON (reduce processed data)
8 stars 0 forks source link

DoubleS1Scatter Tf nn switch #246

Closed ctherreau closed 5 years ago

ctherreau commented 5 years ago

Update CorrectedDoubleS1Scatter to include TensorFlow based position in the same way as in corrections minitree

tunnell commented 5 years ago

Flake8 detected 38 issues on 85bcd82e25deca1dd67798957dd28502678e4336 Visit https://sider.review/gh/repos/50927571/pulls/246 to review the issues.

posted by Sider

tunnell commented 5 years ago

Flake8 detected 8 issues on 6077b3141d8dcbb2beeba4a4b1dcd6b5cc8cf5b4 Visit https://sider.review/gh/repos/50927571/pulls/246 to review the issues.

posted by Sider

ctherreau commented 5 years ago

Some plots to check here : Wiki note

l-althueser commented 5 years ago

Some plots to check; one Kr83m run from SR1 (170206_1255); no cut

cS1_a_nn_tf vs cS2_a_nn_tf int_a_r_3d_nn_tf vs int_a_z_3d_nn_tf

To my knowledge, we shouldn't have plots directly in GitHub (as stated in the PR templates). They can be provided by a wiki note if needed.

feigaodm commented 5 years ago

thanks @l-althueser , I forgot about this rule for calibration data. Maybe @ctherreau can post it somewhere else and link them. Without plots, it's really hard to review.

ctherreau commented 5 years ago

Some plots to check; one Kr83m run from SR1 (170206_1255); no cut cS1_a_nn_tf vs cS2_a_nn_tf int_a_r_3d_nn_tf vs int_a_z_3d_nn_tf

To my knowledge, we shouldn't have plots directly in GitHub (as stated in the PR templates). They can be provided by a wiki note if needed.

Thanks @l-althueser, I change my comment with a wiki link