Open JelleAalbers opened 8 years ago
I've generalized the issue, since even with short pulses it can happen that a pulse starts just outside the event boundary, but ends within it. These pulses should be included along with the event, but currently aren't. We want the events to be complete snapshots of what the channels do. Even for the first few us this matters (e.g. they are routinely used for accidental coincidence studies in XENON100).
When run on events with very large pulses (e.g. the 800us pulses from run 25 the event builder will create event ranges much shorter than the pulses (unless the left and right extension options are set very high). When you process these datasets with pax, the pulses will be truncated considerably.
We can solve this in several ways:
I think the first option is by far the cleanest. We can think about doing this by default or only in a special mode.
See also #43, #315 and 8d1c693a6dd84542836a1ee8c1e81db2ee1de609.