XENON1T / pax

The XENON1T raw data processor [deprecated]
BSD 3-Clause "New" or "Revised" License
16 stars 15 forks source link

correct typo in `add_to_z` #630

Closed pietrodigangi closed 7 years ago

pietrodigangi commented 7 years ago

correct typo in add_to_z assigned value. It was add_to_z = (2.15 + 0.25) * cm -> correct is add_to_z = (2.15 + 0.025) * cm

feigaodm commented 7 years ago

For Xe100 the distance between gate and liquid level is 2.5mm. If we want to set gate to 0, we need 2.5 mm instead of 10 times smaller

feigaodm commented 7 years ago

Maybe modify the one in Xe1T.ini file?

pietrodigangi commented 7 years ago

@feigaodm there was a misunderstanding with Jelle on gitter chat about that value (the typo is actually in the comment above)

pietrodigangi commented 7 years ago

@feigaodm for XENON1T, has this z offset to be the same with impose in the Geant4 code to have the gate at 0? I'm not sure how the value in the Xe1T.ini relates to that one in G4

JelleAalbers commented 7 years ago

Yes, Pietro spotted the inconsistency between comment and config, and I agreed it was a typo. However it's the comment that was incorrect while the config was ok. Should be fixed now.

feigaodm commented 7 years ago

@JelleAalbers Should we change the one in XENON1T.ini to 0? You commented there that we should change it when G4 geometry is updated, and I think it happended long time ago.

JelleAalbers commented 7 years ago

Yes, if the MC files now output positions in the common coordinate system, we can change that setting to 0, and remove the override in https://github.com/XENON1T/pax/blob/master/pax/config/SimulationMCInput.ini.