search

XENON1T / pax

The XENON1T raw data processor [deprecated]
BSD 3-Clause "New" or "Revised" License
16 stars 15 forks source link

Clean up maps and add new S1 and S2 pattern maps #654

Closed l-althueser closed 6 years ago

l-althueser commented 6 years ago

This PR will remove and add some files in the data directory.

  1. New S1 and S2 patterns maps with MC v2.1.0 + geo update including PMT window hit R and angle dependence as shown in this notebook. I opened an issue (#653) for further questions about the S1 patterns. The S2 patterns map is generated exactly as in previous versions (@weiyuehuan pls validate with the notebook).
  2. The fitted patterns map for S2 patterns have to be updated. @pelssers can you do this or is there any script that I could add to this repo on Github?
  3. Many of the maps were already outdated and not used in PAX. These outdated versions were still used in FAX and the config files prepared in #652. I tried to update all of them to the most recent versions.
  4. I think that we have to change the names of the maps also in HAX before we can merge this. (see https://github.com/XENON1T/hax/pull/186)

Data files removed:

I searched and replaced all occurrences of the map name in the PAX repository. This should work out of the box but is not tested (since I don't know how ..).

I could make a separate PR if you don't want to rename the maps.

tunnell commented 6 years ago

Conflict?

feigaodm commented 6 years ago

Hi @l-althueser , can you check this again and resolve the conflicts? Not sure if some more maps has been added. Thanks!

l-althueser commented 6 years ago

I will try to solve the conflicts and revisit all files again. Give me some hours ;)

l-althueser commented 6 years ago

The PR in PAX and HAX (https://github.com/XENON1T/hax/pull/186) are updated and should be checked by someone else. It is not easy to keep track on all map changes but I visited all commits since the last update of the PR and included everything that was missing.

feigaodm commented 6 years ago

Can each map producer help to check whether individial maps are properly renamed and used? It's good that we keep same naming convention in the future. S1 LCE @berget2 S2 LCE @adambrown1 S1 AFT @darrylmasson Pos FDC @jingqiangye FAX @jhowl01 Single Electron @katrinamiller

katrinamiller commented 6 years ago

@feigaodm & @l-althueser - the new naming convention for the single electron maps looks OK!

JosephJHowlett commented 6 years ago

Fine for me as well, thanks for checking

jingqiangye commented 6 years ago

3D FDC maps are correct.

berget2 commented 6 years ago

S1 LCE looks good

On Mon, Feb 5, 2018 at 3:59 PM, Jingqiang Ye notifications@github.com wrote:

3D FDC maps are correct.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/XENON1T/pax/pull/654#issuecomment-363219382, or mute the thread https://github.com/notifications/unsubscribe-auth/AKA8-x1c4dSiViWvTQ1cpZyhFl2u27lcks5tR2uqgaJpZM4RHvf- .

l-althueser commented 6 years ago

Updated to match https://github.com/XENON1T/hax/pull/186