search

XENON1T / pax

The XENON1T raw data processor [deprecated]
BSD 3-Clause "New" or "Revised" License
16 stars 15 forks source link

Don't include inactive PMTs in S1 pattern fit #663

Closed JelleAalbers closed 6 years ago

JelleAalbers commented 6 years ago

The S1 pattern fit calculation currently doesn't account for inactive PMTs when comparing the observed pattern to the MC map. This means the pattern fit values are unnecessarily bad, and the power of S1 pattern fit cut is much reduced.

This fixes the bug. I checked using a simulated 1400 PE S1 from an interaction at (x=0, y=0, z=-50):

Current master:
    s1_pattern_fit = 803
    s1_pattern_fit_hits = 343

After fix:
    s1_pattern_fit = 314
    s1_pattern_fit_hits = 237

At low-energy the effects might be a bit less dramatic, since the S1 hitpatterns are far more stochastic.

As an 'interesting' side effect, this currently changes @sanderbreur's hitpattern-based "saturation" correction (which is unused at the moment) to also fill in the area of dead PMTs using the MC LCE map. Thus the S1 light yield map should be more uniform after applying the correction: would be interesting to check if this is true once we remake the S1 LCE map. Still, we probably don't want this: it means you can't use the saturation correction alongside the current S1 spatial correction. This can be easily fixed, but my mind has stopped working and just fixing this bug is more important.

Thanks to @coderdj for spotting the problem.

feigaodm commented 6 years ago

Thanks @JelleAalbers! For SR1 analysis purpose, we shall modify HAX treemaker to include this list as well. I guess the gains can be extracted from rundb so that we can consider run dependence as well. @skazama , can you modify the corresponding code in HAX and we can regrow minitrees right afterwards.

coderdj commented 6 years ago

@skazama no need. I already modified it. We'll merge that in with the new s2 pattern variable hopefully today.