Closed pdeperio closed 6 years ago
Right, this PR fixes s2_light_yield_map
only.
I was referring to a potential solution to the current development of s2_pattern_fit
in hax, which you had to hardcode for now. So was thinking we could load SR1_parameters
there instead of XENON1T
to grab this file.
Ah, yeah it wouldn't be a bad idea to take snapshots of each .ini as used for each result and keep for such purposes. But really we should not be correcting in hax in this way (or we should reorganize such that such corrections fit into the data flow better).
Forgot to update S2 xy correction map in
SR1_parameters.ini
to v2.2 (as in hax.ini now). This config is mostly used in simulations now, but perhaps we should also use for hax here if not defined there already, for examples2_patterns_file
which has changed inXENON1T.ini
since thepax_v6.8.0
reprocessing, and we need to be consistent now for recalculations.